Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(es): add hashnode.mdx #8517

Merged
merged 5 commits into from
Jun 25, 2024
Merged

Conversation

ItzRoBeerT
Copy link
Contributor

Description (required)

Add new hashnode.mdx translation for es.
Reused the original hashnode.mdx file, from en in order to translate the new file.

Related issues & labels (optional)

  • Closes #
  • Suggested label: i18n

Copy link

vercel bot commented Jun 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 25, 2024 0:34am

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label Jun 13, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 13, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
es guides/cms/hashnode.mdx Localization added, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job @ItzRoBeerT, I left you just a small suggestion for consistency.

src/content/docs/es/guides/cms/hashnode.mdx Show resolved Hide resolved
@dreyfus92
Copy link
Member

@ItzRoBeerT I haven't merged this yet cause the change hasn't been applied 😁

Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work, y'all. @ItzRoBeerT, I saw the suggestion you agreed with by didn't apply, I hope you don't mind I took the liberty to apply it for you!

@yanthomasdev yanthomasdev merged commit aa74328 into withastro:main Jun 25, 2024
8 checks passed
@ItzRoBeerT
Copy link
Contributor Author

Hey @yanthomasdev!
i though i actually applied...
Thank you so much for apply it!
And sorry for the inconvenience!

@ItzRoBeerT ItzRoBeerT deleted the translation-es branch June 25, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants