Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cancel incomplete lunaria preview builds on new commits #8510

Merged
merged 7 commits into from
Jun 14, 2024
Merged

Cancel incomplete lunaria preview builds on new commits #8510

merged 7 commits into from
Jun 14, 2024

Conversation

Fryuni
Copy link
Member

@Fryuni Fryuni commented Jun 13, 2024 •
edited
Loading

Description

Lunaria continues to run after new commits, which wastes a bit of time but, more importantly, may cause a race in the Lunaria preview.

Concurrency options are the same as the CI file:

docs/.github/workflows/ci.yml

Lines 10 to 13 in b5dbd53

# Automatically cancel in-progress actions on the same branch
concurrency:
group: ${{ github.workflow }}-${{ github.event_name == 'pull_request_target' && github.head_ref || github.ref }}
cancel-in-progress: true

@Fryuni Fryuni self-assigned this Jun 13, 2024
@vercel Vercel
Copy link

vercel bot commented Jun 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 14, 2024 7:47pm
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Jun 14, 2024 7:47pm

lorenzolewis
lorenzolewis approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@lorenzolewis lorenzolewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

TheOtterlord
TheOtterlord reviewed Jun 13, 2024
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to cancel the first run
image

@Fryuni
Copy link
Member Author

Fryuni commented Jun 13, 2024

pull_request_target triggers workflows based on the latest commit of the pull request's base branch. So it won't use the fix until it is merged 🙃

@Fryuni Fryuni requested a review from TheOtterlord June 13, 2024 13:15
TheOtterlord
TheOtterlord approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh ok, cool. LGTM then! I'll add this to the merge queue, and will merge after T&D

@TheOtterlord TheOtterlord added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 13, 2024
@sarah11918 sarah11918 merged commit 31a8fdf into main Jun 14, 2024
7 of 8 checks passed
@sarah11918 sarah11918 deleted the fryuni/lunaria-concurrent-workflow branch June 14, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorenzolewis lorenzolewis lorenzolewis approved these changes

@TheOtterlord TheOtterlord TheOtterlord approved these changes

Assignees

@Fryuni Fryuni

Labels
🚨 action Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Fryuni @lorenzolewis @TheOtterlord @sarah11918