Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: static section and updated yml in zerops guide #8496

Merged
merged 23 commits into from
Jun 18, 2024
Merged

feat: static section and updated yml in zerops guide #8496

merged 23 commits into from
Jun 18, 2024

Conversation

nermalcat69
Copy link
Contributor

@nermalcat69 nermalcat69 commented Jun 12, 2024 •
edited
Loading

Description

Zerops made some changes in their zerops yml and added a service for static apps.

Changes

@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 18, 2024 1:05pm

@nermalcat69 nermalcat69 marked this pull request as draft June 12, 2024 16:45
@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 12, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/deploy/zerops.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@nermalcat69 nermalcat69 mentioned this pull request Jun 13, 2024
Merged
@nermalcat69 nermalcat69 marked this pull request as ready for review June 17, 2024 09:47
@nermalcat69 nermalcat69 changed the title Minor: Add Static Section and Update yml in Zerops Deployment Guide (Wip) Minor: Add Static Section and Update yml in Zerops Deployment Guide Jun 17, 2024
@sarah11918 sarah11918 added improve documentation Enhance existing documentation (e.g. add an example, improve description) 3rd-party guide Community submitted CMS, deploy, backend etc. guide labels Jun 17, 2024
sarah11918
sarah11918 reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, @nermalcat69 , and congrats on supporting static sites! 🥳

Just tidying up some formatting/text edits here, and we'll get this merged! 🙌

src/content/docs/en/guides/deploy/zerops.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/zerops.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/zerops.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/zerops.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/zerops.mdx Outdated Show resolved Hide resolved
src/content/docs/en/guides/deploy/zerops.mdx Outdated Show resolved Hide resolved
@vercel vercel bot temporarily deployed to Preview – docs June 18, 2024 12:02 Inactive
@nermalcat69 nermalcat69 changed the title Minor: Add Static Section and Update yml in Zerops Deployment Guide feat: Add Static Section and Update yml in Zerops Deployment Guide Jun 18, 2024
@nermalcat69 nermalcat69 changed the title feat: Add Static Section and Update yml in Zerops Deployment Guide feat: add static section and update yml in zerops deployment guide Jun 18, 2024
@nermalcat69 nermalcat69 changed the title feat: add static section and update yml in zerops deployment guide feat: static section and updated yml in zerops guide Jun 18, 2024
sarah11918
sarah11918 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looking good now! 🥳

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label Jun 18, 2024
@sarah11918 sarah11918 merged commit e5edd8d into withastro:main Jun 18, 2024
7 of 8 checks passed
@jsparkdev jsparkdev mentioned this pull request Jun 19, 2024
Merged
@liruifengv liruifengv mentioned this pull request Jun 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
3rd-party guide Community submitted CMS, deploy, backend etc. guide improve documentation Enhance existing documentation (e.g. add an example, improve description) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nermalcat69 @astrobot-houston @sarah11918