Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: document custom 500 #8495

Merged
merged 16 commits into from
Jun 18, 2024
Merged

feat: document custom 500 #8495

merged 16 commits into from
Jun 18, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jun 12, 2024 •
edited by ematipico
Loading

Description (required)

Documents the usage of custom 500 error pages.

Related issues & labels (optional)

Code PR withastro/astro#11244

florian-lefebvre and others added 9 commits May 24, 2024 13:27
@florian-lefebvre
Update astro-pages.mdx
b4e1bc1
@florian-lefebvre @ematipico
Apply suggestions from code review
775ac40 
Co-authored-by: Emanuele Stoppa <[email protected]>
@florian-lefebvre
Merge branch 'main' into feat/custom-500-improvements
3a16661
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
db2a936 
Co-authored-by: Sarah Rainsberger <[email protected]>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
e8fbb00 
Co-authored-by: Sarah Rainsberger <[email protected]>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
87193d6 
Co-authored-by: Sarah Rainsberger <[email protected]>
@florian-lefebvre @sarah11918
Apply suggestions from code review
4500000 
Co-authored-by: Sarah Rainsberger <[email protected]>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
cbd140c 
Co-authored-by: Sarah Rainsberger <[email protected]>
@florian-lefebvre @sarah11918
Update src/content/docs/en/basics/astro-pages.mdx
15dba1e 
Co-authored-by: Sarah Rainsberger <[email protected]>
@vercel Vercel
Copy link

vercel bot commented Jun 12, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jun 18, 2024 6:14am

@astrobot-houston
Copy link
Contributor

astrobot-houston commented Jun 12, 2024 •
edited
Loading

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en basics/astro-pages.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@florian-lefebvre florian-lefebvre mentioned this pull request Jun 12, 2024
Merged
@sarah11918 sarah11918 added the add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. label Jun 13, 2024
@sarah11918
Copy link
Member

This looks good to me! There was a problem with the deployment build, so I've updated branch so that it will run again. When checks pass, I'll approve!

@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels Jun 13, 2024
sarah11918
sarah11918 approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@sarah11918
Copy link
Member

I am leaving the computer, so this one's on you to merge when you're happy!

@florian-lefebvre
Copy link
Member Author

Alright thanks! The patch is planned for Monday I believe

@florian-lefebvre florian-lefebvre merged commit 871e6d8 into main Jun 18, 2024
8 checks passed
@florian-lefebvre florian-lefebvre deleted the feat/custom-500 branch June 18, 2024 06:51
@jsparkdev jsparkdev mentioned this pull request Jun 18, 2024
Merged
@100gle 100gle mentioned this pull request Jun 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@florian-lefebvre @astrobot-houston @sarah11918 @ematipico