-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translation about stub in layout #3969
Conversation
✅ Deploy Preview for astro-docs-2 ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
My bad, didn't saw the |
Yep, I tested that when there is no translation for that language, it will fall back to English :) |
Sorry, I just broke my main branch by mistake. So I force-pushed it to fix it. Everything is the same as when Alynva approved these changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice effort, team! I will wait for Yan or Chris for final approval on this one, but really appreciate this thoughtful contribution, @imbant ! 🥳
Hi @imbant, we had a team meeting about this one (and, my apologies, I forgot we'd already a long time ago had a discussion months ago!) and our translators at the time decided that it's better NOT to translate this content. In fact, it was my mistake to mark the stubs as Most of our stub pages are really quite small, with little text to translate, so there's not lot of extra benefit from translating them. And then, if we receive an English contribution to make a more full guide, there would be a big difference between the English language page and a not-yet-updated translated page. We think it's better to have those pages fall-back to English rather than have a time where we display a stub for non-English pages when there is actually good content on the English page. Keeping the stubs untranslated means that they will default to English, and we will only mark them as Thank you for starting these translations, even though we can't use them. 😅 We look forward to more contributions from you! 🙌 |
Oops, apparently I missed a meeting! I think we're going to fix the issue a different way, and so we CAN use this! So I'm going to stay out of this and let @Yan-Thomas finish this off. Reopening at this point, since we think we can use it! |
OK. Thanks for the detailed explanation. Just let me know when there is something that I need to change😀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @imbant 🙌
What kind of changes does this PR include?
Description
Add translation about stub. Please see this issue about why I create this PR