Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix exit code for failed permission check #979

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Mar 8, 2024

Changes

The snapshot workflow in #977 returned 0 instead of 1, causing the workflow to not fail for non-admins.

Testing

Not tested but the only issue was the wrong exit code which wouldn't stop the workflow

Docs

N/A doesn't affect users

Copy link

changeset-bot bot commented Mar 8, 2024

⚠️ No Changeset found

Latest commit: 007f3a2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MoustaphaDev
Copy link
Member Author

Thanks for the speedy review!

@MoustaphaDev MoustaphaDev merged commit 910b093 into main Mar 8, 2024
5 checks passed
@MoustaphaDev MoustaphaDev deleted the MoustaphaDev-patch-1 branch March 8, 2024 16:06
@MoustaphaDev
Copy link
Member Author

!preview test-admin-snapshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants