fix: infinite loop regression in literal (parse/ast) mode #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 6908b2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
natemoo-re
commented
Nov 11, 2022
| return true | ||
| case EndExpressionToken: | ||
| p.addLoc() | ||
| shouldExit := p.exitLiteralIM() |
There was a problem hiding this comment.
Immediately check if we should exit after this token is handled
Comment on lines
+2700
to
+2703
| if shouldExit { | ||
| p.im = p.originalIM | ||
| p.originalIM = nil | ||
| } |
There was a problem hiding this comment.
If we should exit, do it! Resets to the previous insertion mode
| p.im = p.originalIM | ||
| p.originalIM = nil | ||
| } | ||
| return true |
There was a problem hiding this comment.
Otherwise, consider this token handled and continue inLiteralIM
matthewp
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
parse. Only caught this whenformaton Astro's main repo was hanging.inLiteralIMto ensure that the mode is exited properly when tokens are unhandled.Testing
Tested locally in the
prettier-plugin-astrorepo, no more hangingDocs
Bug fix only