Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tsx): Collect multibytes characters in skipped script and styles #1033

Merged
merged 2 commits into from
Jul 31, 2024

Conversation

Princesseuh
Copy link
Member

Changes

When I added the ability to skip script and styles, I forgot to take into account that we should still collect the multibytes characters inside of them as we use it to adjust the positions of tags

Additionally, this PR fixes the order in which the end positions are collected, previously we'd collect it before it got adjusted after printing, which lead to the end positions being wrong most of the time. This didn't end up being a problem in the editor tooling, as we don't care too much about end positions (we map from the start position)

Testing

Added a test and updated the tests for the end positions fixes

Docs

N/A

Copy link

changeset-bot bot commented Jul 31, 2024

🦋 Changeset detected

Latest commit: 40ded6f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh Princesseuh merged commit af471f5 into main Jul 31, 2024
5 checks passed
@Princesseuh Princesseuh deleted the fix/multibytes-extract branch July 31, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants