Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow data-astro-reload to take a value #1012

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Allow data-astro-reload to take a value #1012

merged 3 commits into from
Jun 24, 2024

Conversation

matthewp
Copy link
Contributor

Changes

  • Removes the diagnostic disallowing data-astro-reload from having a value.
  • I don't know the context for why this was added, but it prevents people from making the property from being conditional, ala data-astro-reload={false}. As far as I know we don't care about the value on the front-end.
  • 🐛 BUG: data-astro-reload should accept value #1006

Testing

  • Updated the existing tests around this

Docs

N/A, bug fix

Copy link

changeset-bot bot commented Jun 21, 2024

🦋 Changeset detected

Latest commit: 59fa57f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original trigger were support channel threads with data-astro-reload="some-name" and its use on elements where it didn't work. But I have to admit that we overshot the mark by completely disabling expressions. ;-)

.changeset/light-ligers-rhyme.md Outdated Show resolved Hide resolved
@ematipico ematipico merged commit 0bb2746 into main Jun 24, 2024
5 checks passed
@ematipico ematipico deleted the astro-reload-value branch June 24, 2024 08:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants