Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I've been using this plugin in the Vite repo, and I found it to be incredibly helpful in finding common regex bugs, performance improvements, and even potential ReDos security detection. So I made a PR to bring it in here and curious to hear what y'all think 馃槃
The only cumbersome rule I found that might affect contributors is https://ota-meshi.github.io/eslint-plugin-regexp/rules/no-super-linear-backtracking.html. It helps detect security and perf issues, but often times I'm not really sure how to fix it either and simply ignore it. I think it's still useful to have though.
In this PR, I ran
pnpm lint --fix
to let the plugin auto-fix some issues, then manually resolve some regexes myself.Testing
Existing tests should pass.
Docs
n/a. internal change.