fix(dev): prevent comma-separating multiple Set-Cookie headers #9884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 96eb8d7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lilnasy
commented
Jan 30, 2024
| } else { | ||
| _headers['set-cookie'] = headers.get('set-cookie')!; | ||
| } | ||
| _headers['set-cookie'] = headers.getSetCookie(); |
There was a problem hiding this comment.
The fix is this one line, the rest is clerical.
lilnasy
commented
Jan 30, 2024
Comment on lines
+14
to
+23
| '/src/pages/index.js': `export const GET = () => { | ||
| const headers = new Headers(); | ||
| headers.append('x-single', 'single'); | ||
| headers.append('x-triple', 'one'); | ||
| headers.append('x-triple', 'two'); | ||
| headers.append('x-triple', 'three'); | ||
| headers.append('Set-cookie', 'hello'); | ||
| headers.append('Set-Cookie', 'world'); | ||
| return new Response(null, { headers }); | ||
| }`, |
There was a problem hiding this comment.
Copied over from the NodeApp unit test.
ematipico
approved these changes
Jan 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Added a unit test.
Docs
Does not affect usage.