Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vercel): deprecate speedInsights #9598

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Conversation

Copy link

changeset-bot bot commented Jan 3, 2024

🦋 Changeset detected

Latest commit: 1e9092c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review labels Jan 3, 2024
Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecating looks fine to me 👍

Comment on lines +80 to +82
* See [Vercel Speed Insights Quickstart](https://vercel.com/docs/speed-insights/quickstart) for instructions on how to use the library instead.
*
* https://vercel.com/docs/speed-insights/quickstart
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the duplicated links intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are. To me, it didn't seem obvious that the first one would be clickable so I added the link itself to be safe.

Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@ematipico ematipico merged commit bd8fa7a into withastro:main Jan 4, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Jan 4, 2024
@lilnasy lilnasy deleted the fix/9590 branch January 4, 2024 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vercel speed Anaytics - new version VERCEL_ANALYTICS_ID not found
4 participants