Simplify vue appEntrypoint handling #9362
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Simplify
appEntrypoint
handling. Followup from #8794 and #9333This change moves the default export check to runtime in dev. While this means we're unable to use the Astro logger, we can avoid the
this.resolve
,this.load
, andssrLoadModule
calls which can be expensive.With this PR, in dev we will log a warning if
default
is not exported. In build, Rollup will log a warning instead thatdefault
is not exported.Testing
Existing tests should pass.
Docs
n/a. internal change.