Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for client:only hydrator #935

Merged
merged 16 commits into from
Aug 17, 2021
Merged

Add support for client:only hydrator #935

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
92d688f
Adding support for client:only hydration
Jul 29, 2021
a552e72
Adding documentation for client:only
Jul 29, 2021
eead05c
Adding changeset
Jul 29, 2021
6fd4fe8
Updating the test to use a browser-only API
Jul 30, 2021
03807e9
Adding a browser-specific import script, this reproduces the issue wh…
Jul 30, 2021
1264f30
typo fix
Jul 30, 2021
cc61403
removing mispelled test component
Jul 30, 2021
fc5d0f5
WIP: delaying inclusion of component imports until the hydration meth…
Aug 8, 2021
4f1271e
WIP: tweaking the test to use window instead of document
Aug 8, 2021
38fa5b8
When only one renderer is included, use that for client:only hydration
Aug 14, 2021
76cf82f
temporary test script snuck into the last commit
Aug 14, 2021
71d616f
WIP: adding check for a client:only renderer hint
Aug 14, 2021
3024906
refactor: Remove client:only components instead of delaying all compo…
Aug 15, 2021
23a6e6c
Updating the changeset and docs for the renderer hint
Aug 15, 2021
7a9310e
refactor: pull client:only render matching out to it's own function
Aug 15, 2021
10bc040
Updating renderer hinting to match full name, with shorthand for inte…
Aug 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
typo fix
  • Loading branch information
Tony Sullivan committed Aug 17, 2021
commit 1264f30eb1199229033391373b12d09df25b5c27
22 changes: 22 additions & 0 deletions packages/astro/test/fixtures/astro-dynamic/src/components/PersistentCounter.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@

<script>
import './logResize';

let count = parseInt(localStorage.getItem('test:count')) || 0;
$: localStorage.setItem('test:count', count);

function add() {
count += 1;
}

function subtract() {
count -= 1;
}
</script>

<div class="counter">
<button on:click={subtract}>-</button>
<pre>{ count }</pre>
<button on:click={add}>+</button>
</div>

4 changes: 2 additions & 2 deletions packages/astro/test/fixtures/astro-dynamic/src/pages/client-only.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
---
import PersistantCounter from '../components/PersistantCounter.svelte';
import PersistentCounter from '../components/PersistentCounter.svelte';
---
<html>
<head><title>Dynamic pages</title></head>
<body>
<PersistantCounter client:only />
<PersistentCounter client:only />
</body>
</html>