Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small polish to the overlay #9214

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Small polish to the overlay #9214

merged 4 commits into from
Nov 29, 2023

Conversation

Princesseuh
Copy link
Member

Changes

Some small changes that came up from the dev overlay bug bash:

  • Links now open in a new tab
  • "Copy debug info" button now resets automatically after a delay and is a bit more clear
  • "No issues found" alert now has the proper ARIA role

Testing

N/A

Docs

N/A

Copy link

changeset-bot bot commented Nov 28, 2023

🦋 Changeset detected

Latest commit: 6182dd0

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr A PR that includes documentation for review labels Nov 28, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@Princesseuh Princesseuh merged commit 4fe523b into next Nov 29, 2023
13 checks passed
@Princesseuh Princesseuh deleted the feat/overlay-polish branch November 29, 2023 12:52
This was referenced Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants