Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent bumping peer deps #8893

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Prevent bumping peer deps #8893

merged 2 commits into from
Oct 26, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 23, 2023

Changes

The integrations' astro peer dep ranges has been updating, which is a breaking change. I changed it to an explicit version range instead of workspace: so changeset doesn't bump it now. Works especially in combination of the onlyUpdatePeerDependentsWhenOutOfRange experimental option.

The peer dep ranges are all reset to "astro": "^3.0.0"

Testing

Ran pnpm changeset version locally.

Docs

n/a.

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

⚠️ No Changeset found

Latest commit: 3a05ee8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) labels Oct 23, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yikes, good catch!

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will bite us when we are going to do another major release, and the ranges aren't automatically updated. So if you want to go ahead, we must update our internal documentation and remind us that this is a manual step. Why not use workspace:^3.0.0?

@bluwy
Copy link
Member Author

bluwy commented Oct 26, 2023

I'll update the internal docs 👍 workspace:^3.0.0 is currently what's causing the issue and changesets is bumping it every version.

@bluwy
Copy link
Member Author

bluwy commented Oct 26, 2023

@ematipico looks like with the onlyUpdatePeerDependentsWhenOutOfRange config, changesets is smart enough to also bump the peer dep whenever we enter prerelease mode or cut a new major, so looks like no additional docs is needed.

@bluwy bluwy merged commit c897644 into main Oct 26, 2023
13 of 14 checks passed
@bluwy bluwy deleted the peer-deps-begone branch October 26, 2023 10:07
natemoo-re pushed a commit that referenced this pull request Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants