feat(vercel): maxDuration config #8867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7085f7f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: integration
lilnasy
commented
Oct 18, 2023
| runtime: getRuntime(), | ||
| handler, | ||
| launcherType: 'Nodejs', | ||
| maxDuration, |
There was a problem hiding this comment.
This is the new part. Commenting for quick visibility.
Relevant Vercel docs: https://vercel.com/docs/build-output-api/v3/primitives#base-config.
|
It would be great if we can find out what's the maximum allowed, so we can throw an error early. Vercel documentation doesn't mention it, I see what I can do. |
|
Yes, it is 900s for enterprise customers. Although, I'm not sure if custom contracts can allow longer. https://vercel.com/docs/functions/serverless-functions/runtimes#maxduration |
lilnasy
force-pushed
the
feat/vercel-max-duration
branch
from
06daf3c
to
0eb004e
Compare
ematipico
approved these changes
Oct 20, 2023
sarah11918
reviewed
Oct 20, 2023
Co-authored-by: Sarah Rainsberger <[email protected]>
lilnasy
commented
Oct 20, 2023
bluwy
approved these changes
Oct 23, 2023
Merged
natemoo-re
pushed a commit
that referenced
this pull request
Nov 22, 2023
Co-authored-by: Sarah Rainsberger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
Added a fixture and test that
.vc-config.jsonhas the expected field.Docs
Added a section to the README.