Account for pathnames being part of the site config #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). astro-www – ./www🔍 Inspect: https://vercel.com/pikapkg/astro-www/NXqtDnTzmmCt98ZNyR3ka4rrKJk6 astro-docs – ./docs🔍 Inspect: https://vercel.com/pikapkg/astro-docs/FVcTKmCTnSusgFn4s7dwXyhbZvyS |
🦋 Changeset detectedLatest commit: a5a3321 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jasikpark
approved these changes
Jul 26, 2021
packages/astro/test/fixtures/astro-global/src/pages/index.astro
Outdated
Show resolved
Hide resolved
jasikpark
approved these changes
Jul 26, 2021
|
Thanks! |
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Account for pathnames being part of the site config * Adds a changeset * Don't toString the site in the test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688
Changes
This makes it so that we use buildOptions.site consistently throughout the internals. Instead of just using it to get the origin, use it fully to construct URLs, which gives us correct URLs in the case where the site includes a pathname other than
/.Testing
Updated existing tests
Docs
Bug fix