Refactor mdx remark plugins #8430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4a7931b The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
feat: markdown
bluwy
commented
Sep 6, 2023
| @@ -61,7 +62,6 @@ export async function renderMarkdown( | |||
| frontmatter: userFrontmatter = {}, | |||
| } = opts; | |||
| const input = new VFile({ value: content, path: fileURL }); | |||
| const scopedClassName = opts.$?.scopedClassName; | |||
There was a problem hiding this comment.
I removed this since it seems to only been used for Astro-flavoured markdown, which we don't use anymore.
ematipico
approved these changes
Sep 7, 2023
matthewp
approved these changes
Sep 7, 2023
natemoo-re
approved these changes
Sep 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
remarkShikiandremarkPrismcode between@astrojs/markdown-remarkand@astrojs/mdx.remarkShikiandremarkPrismcode to@astrojs/markdown-remarkTesting
Existing markdown tests should pass. Also ran the mdx, markdown-remark, astro tests locally.
Docs
n/a. internal refactor.