Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two errors for use in docs #7445

Merged
merged 2 commits into from
Jun 22, 2023
Merged

Fix two errors for use in docs #7445

merged 2 commits into from
Jun 22, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Jun 22, 2023

Changes

  • Uses a single template string instead of multiple joined together with +
    Docs doesn’t support parsing concatenated strings resulting in the following Markdown:

    > **PrerenderDynamicEndpointPathCollide**: Could not render `PATHNAME` with an `undefined` param as the generated path will collide during prerendering. ` +
             `Prevent passing `undefined` as `params` for the endpoint's `getStaticPaths()` function, ` +
             `or add an additional extension to the endpoint's filename. (E03026)
             `or add an additional extension to the endpoint's filename.
  • Fixes an error that wasn’t being picked up because its comment opened with /* instead of /**.

Didn’t include a changeset as this is basically only a style change.

Testing

Existing tests should pass.

Docs

Docs-fix only.

@delucis delucis requested a review from a team as a code owner June 22, 2023 09:24
@changeset-bot
Copy link

changeset-bot bot commented Jun 22, 2023

⚠️ No Changeset found

Latest commit: 1b523e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 22, 2023
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @delucis!

@delucis delucis changed the title Fix an error message for use in docs Fix two errors for use in docs Jun 22, 2023
@delucis delucis merged commit 03b7d17 into main Jun 22, 2023
@delucis delucis deleted the chris/error-fixes branch June 22, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants