Update example dependencies versions with a script #7367
Conversation
|
|
Yeah it should still pass. I've been seeing similar failures recently here where CI would bail completely without any reason. I've merged the branch to re-trigger CI again. |
| // Update dependencies | ||
| for (const depName of Object.keys(packageJson.dependencies ?? [])) { | ||
| if (packageToVersions.has(depName)) { | ||
| packageJson.dependencies[depName] = `^${packageToVersions.get(depName)}`; |
There was a problem hiding this comment.
nit: should we just pin ~ - bug fixes?
Personally, I would pin the versions without ranges. It's known that there are libraries that break the CIs with patches.
There was a problem hiding this comment.
Worth bearing in mind we’re bumping astro or @astrojs/* integrations in our example templates here. If we break CI with patches, that’s probably on us, no?
There was a problem hiding this comment.
I think ^ should be good here as it's what we used to use too. Since these are our packages that we're bumping, I don't think we're making breaking changes in minors or patches that needs this restriction. (EDIT: I sent this before seeing Chris's comment)
Changes
Add a script to update the example deps versions.
Testing
Manually ran
pnpm run versionlocallyDocs
n/a