Use AstroError for Astro.glob errors #7219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 468d1a7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ematipico
approved these changes
May 26, 2023
Princesseuh
reviewed
May 26, 2023
Princesseuh
reviewed
May 26, 2023
Princesseuh
reviewed
May 26, 2023
sarah11918
reviewed
May 26, 2023
There was a problem hiding this comment.
Thanks @bluwy! No errors in these, but see what you think of my suggestions below! ;)
Co-authored-by: Erika <[email protected]>
Co-authored-by: sarah11918 <[email protected]>
matthewp
approved these changes
May 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Followup to #7204
Use
AstroErrorforAstro.globerrors so we get better error messagesTesting
Added e2e tests. And manually tested it.
Docs
Added new errors!
/cc @withastro/maintainers-docs for feedback!