Renaming to import.meta.fetchContent #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewp
reviewed
Apr 9, 2021
| @@ -0,0 +1,20 @@ | |||
| /** | |||
| * Codegen utils | |||
There was a problem hiding this comment.
Happy to see codegen split up a little bit.
drwpow
force-pushed
the
fetch-collections
branch
3 times, most recently
from
dcbd134
to
70c8ad5
Compare
Change of plans—maintain parity with Snowpack and Vite because our Collections API will use a different interface
drwpow
force-pushed
the
fetch-collections
branch
from
70c8ad5
to
90540ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Identical to #68, except we rename
import.meta.globtoimport.meta.fetchContent. A few reasons:createContext()API, we thought we could useimport.meta.globto load markdown. Turns out that it‘s very unwieldy when you want a magic function to load your contentimport.meta.glob, which isn‘t great (what if you actually wanted that?)Made as a separate branch from #68 as to not disrupt demos.
Testing
Docs