Disable Vite optimizer for sync and config loading #6902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 36a2e5e The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Disable the optimizer with
optimizeDeps.disabledso that the optimize metadata is not overwrittenExplanation
In the astro docs repo, what's happening is that:
astro.config.tswith Vite server, sees./node_modules/.vite/deps/_metadata.json, but hash mismatched so remove the file../node_modules/.vite/deps/_metadata.json.This causes the Astro dev server startup to always re-optimize on step 2, which makes startup slow. This PR prevents step 1 from happening.
Result
This removes 200ms of scanning and 600ms of prebundling for the Astro docs repo for warm startups.
Testing
Manual testing in astro docs repo
Docs
n/a. bug fix.