Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unique workspace name #6836

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Ensure unique workspace name #6836

merged 1 commit into from
Apr 13, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Apr 13, 2023

Changes

A small chore to ensure workspace packages have a unique name. This is required when I upgrade turbo, but for some reason turbo also scans gitignored packages (e.g. build output), and those build output have empty names causing vercel/turbo#3340

So I stick with the old turbo version for now, but thought it would be good to do this cleanup.

Testing

Existing tests should pass.

Docs

n/a. cleanup.

@changeset-bot
Copy link

changeset-bot bot commented Apr 13, 2023

⚠️ No Changeset found

Latest commit: b592ea5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Apr 13, 2023
Copy link
Member

@MoustaphaDev MoustaphaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantestic!

@bluwy bluwy merged commit 1fa0416 into main Apr 13, 2023
@bluwy bluwy deleted the unique-workspace-name branch April 13, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants