-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix experimental.assets's Squoosh service not working on Netlify and Vercel SSR #6765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a7e3ef3 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This reverts commit e9d1221.
!preview image-wasm-ssr |
|
ematipico
approved these changes
Apr 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I have tried a thousand ways to bundle
.wasm
files on SSR hosts and concluded that: There's no way. Every runtime has its own way of doing it (Vercel supports.wasm?module
imports, Netlify doesn't have an option, who knows what other are doing).A promising way was to use Vite's WASM imports, but this doesn't work either for multiple reasons, notably those don't work in SSR the way you would expect them to. Both
?init
and?url
don't work because the.wasm
files end at the wrong place and for the former, it only supports fetching the wasm file so it's ultimately unsuitable for SSR. Even if that worked, some SSR hosts just won't include the.wasm
files in their final bundle (ex: Netlify)So I went the shameful way. I inlined them.
Testing
Tested manually. See <https://mechanical-magnitude-princesseuh.vercel.app/
Docs
N/A