Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mdx and markdoc integrations return type #6552

Merged
merged 2 commits into from
Mar 16, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 15, 2023

Changes

Fix #6520

Return the integrations with AstroIntegration type, and type the private APIs used by the integrations internally only.

Testing

Manually check the .d.ts generated export as AstroIntegration and not IntegrationWithPrivateHooks

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2023

🦋 Changeset detected

Latest commit: 486457b

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Mar 15, 2023
@bluwy bluwy merged commit 392ba3e into main Mar 16, 2023
@bluwy bluwy deleted the fix-mdx-markdoc-types branch March 16, 2023 15:02
@astrobot-houston astrobot-houston mentioned this pull request Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript error with @astrojs/mdx 0.18.0
2 participants