[@astrojs/image] Handle missing trailing slash in processStaticImage #6421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code path changed by this commit isn't only taken when running using Vite. If the site is configured with a base url which is different from `/` but does **not** end with `/` (for example, because `trailingSlash` is set to `never`), the `- 1` results in an off-by-one error when truncating the URL. By checking if the base url ends with `/`, we can determine the right length for the prefix to truncate.
🦋 Changeset detectedLatest commit: 67a8800 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The code path changed by this commit isn't only taken when running using Vite. If the site is configured with a base url which is different from
/but does not end with/(for example, becausetrailingSlashis set tonever), the- 1results in an off-by-one error when truncating the URL.By checking if the base url ends with
/, we can determine the right length for the prefix to truncate.Testing
Tested manually on a repository which exhibited the issue:
config.base == '/', before change: workingconfig.base == '/pr-preview/pr-5', before change: error messages in the log indicate that the integration is looking for files beginning with5/path/to/the/imageconfig.base == '/', after change: workingconfig.base == '/pr-preview/pr-5': after change: error messages are gone and images are generated as expected.Docs
No docs added since this is only a bug fix for a behavior that should have already been working.