Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use undici's FormData for polyfilling #6413

Merged
merged 2 commits into from
Mar 3, 2023
Merged

Conversation

Princesseuh
Copy link
Member

Changes

Previously we used a random polyfill package for FormData, but undici actually provide this so we can use theirs instead.

Testing

Tests should pass!

Docs

Added some comments telling us which polyfills to remove in future node versions

@Princesseuh Princesseuh requested a review from a team as a code owner March 3, 2023 12:39
@changeset-bot
Copy link

changeset-bot bot commented Mar 3, 2023

🦋 Changeset detected

Latest commit: 60c0eeb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Princesseuh Princesseuh changed the title Fix/undici formdata Use undici's FormData for polyfilling Mar 3, 2023
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs LGTM!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good! CI needs to be rerun, but once tests are passing this should be good to go.

@Princesseuh Princesseuh merged commit 0abd1d3 into main Mar 3, 2023
@Princesseuh Princesseuh deleted the fix/undici-formdata branch March 3, 2023 13:47
@astrobot-houston astrobot-houston mentioned this pull request Mar 3, 2023
@Princesseuh Princesseuh self-assigned this Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants