Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve server-stress benchmark comment #6405

Merged
merged 1 commit into from
Mar 3, 2023
Merged

Improve server-stress benchmark comment #6405

merged 1 commit into from
Mar 3, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 2, 2023

Changes

Improve !bench server-stress comment output. It should print a nicer markdown table now:

Before:

18k requests in 30.05s, 1.23 GB read

After:

Avg Stdev Max
Latency 680.22 ms 220.43 ms 1398 ms
Avg Stdev Min Total in 30s
Req/Sec 1449.54 73.74 1192 43.5k requests
Bytes/Sec 103 MB 5.24 MB 84.8 MB 3.09 GB read

Testing

Tested by running pnpm benchmark server-stress locally.

Docs

n/a. internal tooling.

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2023

⚠️ No Changeset found

Latest commit: c374c6d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@delucis
Copy link
Member

delucis commented Mar 2, 2023

Can I push back on the “Docs: n/a. internal tooling”? 😅

Given @ematipico’s recent feedback, would be good to add a note to CONTRIBUTING.md saying that this ! command exists.

@bluwy
Copy link
Member Author

bluwy commented Mar 2, 2023

I've recently made the docs change at #6396, a bit mixed up in that PR but I've got a couple reviews on it 😬

@delucis
Copy link
Member

delucis commented Mar 2, 2023

Oh, sweet! Sorry I missed that. Nice to see this getting cleaned up, improved, and documented. Great work @bluwy 🙌

@bluwy bluwy merged commit 13f6f59 into main Mar 3, 2023
@bluwy bluwy deleted the bench-stress-comment branch March 3, 2023 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants