Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): ensure underscore ignores only child paths of the content directory. #6330

Merged
merged 6 commits into from
Feb 23, 2023

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Feb 22, 2023

Changes

Fix #6329

Testing

Tested manually and added unit tests to check that the getEntryType function returns correctly when there's an underscore above the content directory folder tree

Docs

Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Feb 22, 2023

🦋 Changeset detected

Latest commit: 8ad55e1

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@MoustaphaDev MoustaphaDev marked this pull request as draft February 22, 2023 16:24
@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 22, 2023
@MoustaphaDev MoustaphaDev marked this pull request as ready for review February 22, 2023 18:40
@MoustaphaDev MoustaphaDev changed the title fix(content): only ignore paths inside the content directory when preprended with underscore fix(content): ensure underscore ignores only child paths of the content directory. Feb 22, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fix, nice tests. Thank you! 🙌

@natemoo-re natemoo-re merged commit f91a7f3 into main Feb 23, 2023
@natemoo-re natemoo-re deleted the moustapha/dont-ignore-underscore-above-cc-dir branch February 23, 2023 15:19
@astrobot-houston astrobot-houston mentioned this pull request Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unknown Content Collection Error when parent directory starts with an underscore
2 participants