Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deno fix #6131 #6248

Merged
merged 11 commits into from
Feb 16, 2023
Merged

Deno fix #6131 #6248

merged 11 commits into from
Feb 16, 2023

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Feb 15, 2023

Changes

fix #6131

Testing

Docs

@changeset-bot
Copy link

changeset-bot bot commented Feb 15, 2023

🦋 Changeset detected

Latest commit: 54e7b7d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) labels Feb 15, 2023
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing stuff, thank you for the fix!

@natemoo-re natemoo-re merged commit ef5cea4 into withastro:main Feb 16, 2023
@astrobot-houston astrobot-houston mentioned this pull request Feb 16, 2023
@JerryWu1234 JerryWu1234 deleted the deno_fix branch February 16, 2023 15:36
matthewp added a commit that referenced this pull request Feb 17, 2023
This reverts commit ef5cea4.
matthewp added a commit that referenced this pull request Feb 17, 2023
* Revert "Deno fix #6131 (#6248)"

This reverts commit ef5cea4.

* Create gold-months-live.md
liruifengv pushed a commit to liruifengv/astro that referenced this pull request Feb 18, 2023
* Revert "Deno fix withastro#6131 (withastro#6248)"

This reverts commit ef5cea4.

* Create gold-months-live.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno SSR with prerender=true complains about invalid URL scheme
2 participants