Allow no config #61
Allow no config #61
Conversation
| if (!config.projectRoot) config.projectRoot = '.'; | ||
| if (!config.astroRoot) config.astroRoot = './astro'; | ||
| if (!config.dist) config.dist = './_site'; | ||
| if (!config.public) config.public = './public'; |
There was a problem hiding this comment.
This is kinda dumb; can be improved. I just didn‘t want to add deepmerge just yet as that can blow away user settings if not configured properly
| projectRoot: '.', | ||
| astroRoot: './astro', | ||
| dist: './_site', | ||
| }; |
There was a problem hiding this comment.
Only deleted tests that had stock configurations; left other tests‘ configs that expanded on these
| '.jsx': 'react' | ||
| } | ||
| }; | ||
| ``` |
There was a problem hiding this comment.
Added first pass at config docs
| @@ -50,7 +72,7 @@ If you‘ve used [Svelte][svelte]’s styles before, Astro works almost the same | |||
| <div class="scoped">I’m a scoped style</div> | |||
| ``` | |||
|
|
|||
| #### Sass | |||
| #### 👓 Sass | |||
There was a problem hiding this comment.
I’m 13 and need emojis on things apparently
| const astroConfig = await loadConfig(rawRoot); | ||
| return cmd(astroConfig); | ||
| } catch (err) { | ||
| console.error(colors.red(err.toString() || err)); |
There was a problem hiding this comment.
err.toString() || err might be a crutch; I just do this out of habit whenever a stack trace is 100% not helpful and I want to hide it. Config validation is one such case
| const type = (thing: any): string => (Array.isArray(thing) ? 'Array' : typeof thing); | ||
|
|
||
| /** Throws error if a user provided an invalid config. Manually-implemented to avoid a heavy validation library. */ | ||
| function validateConfig(config: any): void { |
There was a problem hiding this comment.
jsonschema is nice but I only just now realized how heavy it is 🙃
There was a problem hiding this comment.
Our jsonschema object always gets out of date in Snowpack, I wish TS had a better idea of runtime type checking.
There was a problem hiding this comment.
I ran across Runtypes not too long ago. It‘s trying to be essentially a runtime for TS types. Could be something we look into, but it‘s about the same weight as jsonschema/probably has the same issues of keeping it updated.
Changes
I wanted to set up more Astro projects without needing a
astro.config.mjs, so I added basic defaults and very simple config validation.Testing
Docs
No docs changes (I think)