fix: Failed to execute 'encode' on 'TextEncoder': parameter 1 is not of type 'String' in Edge Runtime SSR #6070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e306ded The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
@AirBorne04 Hm, still seeing |
|
These fixes are only for the issues in core / to fix eg cloudflare for now. The solid + vercel needs an additional fix in the vercel adapter. |
bholmesdev
approved these changes
Jan 31, 2023
bholmesdev
reviewed
Jan 31, 2023
1 task
1 task
AirBorne04
changed the title
AirBorne04
added
adapter-cloudflare
pkg: vercel
This was
linked to
issues
Feb 1, 2023
1 task
1 task
bholmesdev
approved these changes
Feb 1, 2023
Merged
matthewp
pushed a commit
that referenced
this pull request
Feb 3, 2023
…of type 'String' in Edge Runtime SSR (#6070) * minor fixes for errors related to vercel SSR in core * yielding empty string instead of nothing, to not exit the iterator --------- Co-authored-by: AirBorne04 <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Error: Pa is not supported in the browser, returning undefinedthat is a vercel adapter issue only and we need to update the build steps there.Testing
Tested example applications for react and solid on vercel.
Docs