Improve top-level return error

[natemoo-re]

Changes

• Closes "Top-level return cannot be used inside an ECMAScript module" #5922
• Fixes some problems with our error handling in dev. We "enhance" compiler errors by doing a second esbuild pass for possible frontmatter errors, but there were two problems here:
  1. We weren't checking if the error actually came from the frontmatter first.
  2. esbuild doesn't support top-level return (for obvious reasons) so any code using return Astro.redirect() would always fail with this message. As a fix, we now replace all instances of return with throw before scanning with esbuild.

Testing

Tested manually as the exact error messages here are subject to change

Docs

QoL improvement only

[changeset-bot]

🦋 Changeset detected

Latest commit: 91769a7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR