Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .astro/ to .gitignore in example projects #5841

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 12, 2023

Changes

  • Add .astro/ to .gitignore in example projects
  • Delete .astro/ from the with-content example that had already committed this.

Testing

Existing tests should pass.

Docs

n/a — we’re already recommending folks .gitignore these files in their own projects.

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2023

⚠️ No Changeset found

Latest commit: ed89339

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@bholmesdev bholmesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Turn that gitignition and drive this PR to merged

@matthewp matthewp merged commit 1d43a3a into main Jan 12, 2023
@matthewp matthewp deleted the chris/gitignore-generated-types-in-examples branch January 12, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants