Drop Node 14 in CI for Node 16 and add Node 18 to the matrix #5768
+138
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a63b598 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Hmm seems like some tests in Netlify and Node integrations is failing. Will take a look. Overall, things do look faster though! |
github-actions
bot
added
the
pkg: integration
Princesseuh
commented
Jan 6, 2023
| @@ -104,19 +104,29 @@ export const createExports = (manifest: SSRManifest, args: Args) => { | |||
| // The fetch API does not have a way to get multiples of a single header, but instead concatenates | |||
| // them. There are non-standard ways to do it, and node-fetch gives us headers.raw() | |||
| // See https://github.com/whatwg/fetch/issues/973 for discussion | |||
There was a problem hiding this comment.
I did not enjoy going down this rabbit hole, hurt me right in the computer
github-actions
bot
added
the
pkg: astro
matthewp
approved these changes
Jan 6, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Title is self-explanatory! Hopefully this result in a faster CI across the board
Fix #5749
Testing
Testing in local, tests runs fine on Node 18! We'll see what CI tells us.
Docs
N/A