Update telemetry to use new errors information

[Princesseuh]

Changes

This PR updates telemetry events so it uses our new AstroError's data when possible. Most importantly, this allows us to have much better information about our own errors in our stats, since we can safely extract the entire error message anonymized + have a cool name and errorCode to filter errors by. The previous anonymizing logic is kept for unknown errors, so we can still get a basic idea of what happened just in case

Additionally, this PR adds telemetry for errors encountered in dev, as previously we'd only get telemetry for dev server stops.

Testing

Added a test for a error event using our own errors, updated tests that needed it. Made it so telemetry doesn't work in tests to avoid triggering it unnecessarily

Docs

N/A

[changeset-bot]

⚠️ No Changeset found

Latest commit: 736ed5a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[Princesseuh]

The logic here is the same one that generates the error reference on the docs, which has been proven to work:tm:

[matthewp]

Is this the first time we are sending errors to telemetry? Assuming so, can we have some tests that include non-anonymous error messages to verify that we are stripping them correctly (or just not sending the message, if that is the intent).

[Princesseuh]

Is this the first time we are sending errors to telemetry? Assuming so, can we have some tests that include non-anonymous error messages to verify that we are stripping them correctly (or just not sending the message, if that is the intent).

It's actually not the first time! The code for reporting errors is from pre-1.0 and hasn't been changed (apart from the fact that we now exclusively use it for unknown errors, whereas before it was used for both known and unknown errors)

[delucis]

Approving as docs because this doesn’t actually require docs.

[matthewp]

@Princesseuh Looked over the tests and the only one I think we should add for now is one to verify that the stack trace is not included. Looking at the code I'm pretty sure it will not be, but it would be good to have a test to verify and enforce that going forward.

[aFuzzyBear]

I know this method 😃

[aFuzzyBear]

😎

[aFuzzyBear]

tel you what, this looks really good...💚