Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests with node 18 #5528

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Fix tests with node 18 #5528

merged 3 commits into from
Dec 6, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 5, 2022

Changes

Handle fetching URLs in Node 18. Node >= 17 sets the DNS resolution to verbatim by default which changes how localhost resolves to 127.0.0.1 or [::1].

Extra context: #5266 (comment)

Testing

All tests should pass. This should also make vite-ecosystem-ci pass.

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 881b946

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 5, 2022
@bluwy bluwy merged commit e97fa9c into main Dec 6, 2022
@bluwy bluwy deleted the fix-ci-node18 branch December 6, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @matthewp