Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration READMEs code block sweep 馃Ч #5455

Merged
merged 2 commits into from
Nov 22, 2022
Merged

Conversation

delucis
Copy link
Member

@delucis delucis commented Nov 22, 2022

Changes

Quick sweep through integration READMEs to fix up some code blocks

Includes:

  • Fix an unclosed code block in Tailwind README.
  • Move titles to comments instead of custom title="" attribute to make that context available on GitHub/npm (including updating any line number annotations to take this into account).
  • Rework Netlify example to avoid reliance on ins/del annotations that won鈥檛 work outside of the docs site.
  • Rework a Deno example for the same reason.
  • A couple other small fixes.

Testing

Docs only.

Docs

Docs only /cc @withastro/maintainers-docs for feedback!

@delucis delucis requested a review from a team as a code owner November 22, 2022 14:49
@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2022

鈿狅笍 No Changeset found

Latest commit: 7bbc8ca

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Nov 22, 2022
@sarah11918
Copy link
Member

These all look great, @delucis, thanks!

@delucis delucis merged commit fcada72 into main Nov 22, 2022
@delucis delucis deleted the chris/integration-readmes branch November 22, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants