Use Vite's resolve to resolve paths for client:only

[matthewp]

Changes

• Use Vite (Rollup) resolve method to resolve within the compiler.
• This is just used for client:only resolution.
• Fixes case where importing a tsx component without the extension.
• Fixes imported css file classes don't get loaded on SSG build when using client:only=react #5167

Testing

• New test case added

Docs

N/A, bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 3ea4582

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[matthewp]

@bluwy would love to get your opinion on this since you worked on this problem before. Any reason not to use Vite resolve here?

[bluwy]

It doesn't use Vite resolve because it doesn't need to when compiling. We only need to make sure that path is import-able when the astro-island imports it.

I'm not sure if this PR is the right move here. I think we might need to fix how vite-plugin-css links the styles up, maybe the missing extension is causing incorrect checks.

[matthewp]

@bluwy Yeah, you're right. I removed that and instead made it so that the analyzer always fully resolves via the specifier to keep track of these.

[tony-sull]

let Vite handle the resolve so we don't worry about extensions, makes sense!