Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent astro-scripts from being released #5257

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Conversation

matthewp
Copy link
Contributor

Changes

  • Ignores astro-scripts in changesets, as it's not a real package.
  • Noticed in [ci] release #5239 that it's currently scheduled to be released. Hoping this change fixes that.

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 31, 2022

⚠️ No Changeset found

Latest commit: 70d310c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@bluwy bluwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's currently not released as it's private, so changeset only updates its changelog. Do we want to remove astro-scripts's changelog too?

@matthewp
Copy link
Contributor Author

matthewp commented Oct 31, 2022

It says it's going to be released in this PR: #5239

Screen Shot 2022-10-31 at 9 38 14 AM

@bluwy
Copy link
Member

bluwy commented Oct 31, 2022

Ah yeah it would be released but it won't get published. It looks like we have done a few releases of it before too. If we want to stop releasing it altogether (which I think makes sense), I think we could remove the linked changelog too.

@matthewp matthewp merged commit 4f9391b into main Oct 31, 2022
@matthewp matthewp deleted the ignore-astro-scripts branch October 31, 2022 14:14
matthewp added a commit that referenced this pull request Oct 31, 2022
matthewp added a commit that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants