Export Cloudflare runtime types #5230
Conversation
🦋 Changeset detectedLatest commit: be1a1e4 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: integration
| @@ -0,0 +1,8 @@ | |||
| export type { | |||
There was a problem hiding this comment.
Looks good! What's the reason for this manual .d.ts instead of emitting types when building to dist/?
There was a problem hiding this comment.
We do emit types to dist. But TypeScript doesn't read the exports field (in certain versions of TypeScript) and so it has to find them at the root like this.
There was a problem hiding this comment.
Ahhh, right — would it make sense to update the build script to astro-scripts build \"src/**/*.ts\" && tsc && cp dist/runtime.d.ts runtime.d.ts and .gitignore the one in root?
There was a problem hiding this comment.
I think this approach is simpler than depending on a build that could be changed accidentally.
There was a problem hiding this comment.
I thought the manual version might be prone to becoming out of date if we change src and not this file, but if the runtime file won’t change very often maybe that’s fine 👍
There was a problem hiding this comment.
Yeah, that is a risk. We are doing this the same way in the main astro package. Not sure if there's a good solution.
Changes
Testing
Tested with a project
Docs
N/A