Refactor rendering for testing #5071
Conversation
|
github-actions
bot
added
the
pkg: astro
| return render`<div>${renderSlot(result, slots['myslot'])}</div>`; | ||
| }); | ||
|
|
||
| const Page = createAstroJSXComponent(() => { |
There was a problem hiding this comment.
Can create an Astro JSX component in plain JS now!
| }) | ||
|
|
||
| it('Can render slots', async () => { | ||
| const Wrapper = createComponent((result, _props, slots = {}) => { |
There was a problem hiding this comment.
Can create Astro components in plain JS now.
matthewp
force-pushed
the
name-slot-astro
branch
from
05683e4
to
5cf1cf8
Compare
|
!bench |
|
Node: 14 Node: 16 |
|
Nice! ~1k more requests in the same time. I think this comes down to the fact that we are now setting up this |
|
I think we can do more to make this nice from a public API perspective. Probably most of the params we treat as required should not actually be required. We want them to be required internally so we get things like logging, but a public API would probably only need the request object and the page component. We can improve from here though |
Changes
core/renderto make it easier to test. The goal is to be able to create rendering tests directly in JavaScript without the need for fixtures.core/rendernow has 2 new types:Environmentis an object that contains things that do not change between requests, such as the logging options, the routeCache, the markdown options, etc.RenderContextis an object that contains things specific to a request, such as the request object and the scripts/styles that need to be included.Testing
Docs
N/A, internal refactor