Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected the getImage() paramaters #5040

Merged
merged 1 commit into from
Oct 10, 2022
Merged

Corrected the getImage() paramaters #5040

merged 1 commit into from
Oct 10, 2022

Conversation

mandar1jn
Copy link
Contributor

Changes

This corrects the arguments passed into the getImage() function for the Image integration

Testing

No testing needed as it's a simple markdown change

Docs

I'll make a PR to the docs too

@mandar1jn mandar1jn requested a review from a team as a code owner October 10, 2022 14:35
@changeset-bot
Copy link

changeset-bot bot commented Oct 10, 2022

⚠️ No Changeset found

Latest commit: a2d2cc8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 10, 2022
mandar1jn added a commit to mandar1jn/astro-docs that referenced this pull request Oct 10, 2022
Reviewed the getImage() documentation to be in line with withastro/astro#5040
@mandar1jn
Copy link
Contributor Author

Created withastro/docs#1756 as parody

@mandar1jn
Copy link
Contributor Author

I'd also like to request for the hacktoberfest-accepted tag to be added please

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, the text, as long as @tony-navillus signs off on this as the preferred documentation example!

@matthewp
Copy link
Contributor

That is the correct signature of getImage

@matthewp matthewp merged commit c5484ad into withastro:main Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants