Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: updates <Picture /> to pass HTML attributes down to the <img /> element #5038

Merged
merged 8 commits into from
Oct 20, 2022
Merged

fix: updates <Picture /> to pass HTML attributes down to the <img /> element #5038

merged 8 commits into from
Oct 20, 2022

Commits on Oct 10, 2022

  1. fix: also pass attrs to underlying img 

    `class` for direct img styling, `width` & `height` to prevent layout shift, etc need to be passed to the underlying img tag to work.
    @emmanuelchucks
    emmanuelchucks committed Oct 10, 2022
    Configuration menu
    Copy the full SHA
    13e83df View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2022

  1. remove redundant attr from picture tag

    @emmanuelchucks
    emmanuelchucks committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    e9daca6 View commit details
    Browse the repository at this point in the history

  2. revert to previous commit 

    - seemed to break some tests
- can't deal with fixing that right now, maybe later
    @emmanuelchucks
    emmanuelchucks committed Oct 15, 2022
    Configuration menu
    Copy the full SHA
    99f94b6 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2022

  1. Merge branch 'main' into patch-1

    Tony Sullivan committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    805786c View commit details
    Browse the repository at this point in the history

  2. only passing attributes to the img

    Tony Sullivan committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    76836bc View commit details
    Browse the repository at this point in the history

  3. adding a note to the README

    Tony Sullivan committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    586dcc7 View commit details
    Browse the repository at this point in the history

  4. chore: add changeset

    Tony Sullivan committed Oct 18, 2022
    Configuration menu
    Copy the full SHA
    f730b48 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Merge branch 'main' into patch-1

    Tony Sullivan committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    01c72fd View commit details
    Browse the repository at this point in the history