Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run astro check on all examples in CI #5022

Merged
merged 9 commits into from
Oct 12, 2022
Merged

Run astro check on all examples in CI #5022

merged 9 commits into from
Oct 12, 2022

Conversation

Princesseuh
Copy link
Member

Changes

Add a workflow to run astro check on all examples when they're modified / types are modified

Testing

It's tests

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 4074216

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the 🚨 action Modifies GitHub Actions label Oct 7, 2022
@Princesseuh Princesseuh marked this pull request as draft October 7, 2022 21:02
@Princesseuh Princesseuh changed the title Run astro check on all examples in CI [WIP] Run astro check on all examples in CI Oct 7, 2022
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Oct 11, 2022
@Princesseuh Princesseuh changed the title [WIP] Run astro check on all examples in CI Run astro check on all examples in CI Oct 11, 2022
@Princesseuh Princesseuh marked this pull request as ready for review October 11, 2022 20:30
matthewp
matthewp approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 not as many changes as I was expecting

@Princesseuh Princesseuh merged commit f604ef6 into main Oct 12, 2022
@Princesseuh Princesseuh deleted the astro-check-ci branch October 12, 2022 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp approved these changes

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Princesseuh @matthewp @bluwy