Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move astro/config into src and typecheck #5013

Merged
merged 2 commits into from
Oct 7, 2022
Merged

Move astro/config into src and typecheck #5013

merged 2 commits into from
Oct 7, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Oct 7, 2022

Changes

Testing

  • Typechecks now, that's a test!

Docs

N/A, bug fix

@changeset-bot
Copy link

changeset-bot bot commented Oct 7, 2022

🦋 Changeset detected

Latest commit: 2c9cf58

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Oct 7, 2022
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Bookmarking this PR, perfect example of why TypeScript is in fact worth the extra effort 🚀

@matthewp matthewp merged commit ffbe4e7 into main Oct 7, 2022
@matthewp matthewp deleted the fix-get-viteconfig branch October 7, 2022 14:30
@astrobot-houston astrobot-houston mentioned this pull request Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getViteConfig() throws an "ERR_MODULE_NOT_FOUND" error
2 participants