[@astrojs/image]: Fix <Picture /> component with query string

[panwauu]

Changes

• When the file extension is created the query parameters are removed
• By removing the query parameters only after the dot of the file extension, we should not have any problem with question marks in filenames/paths/...

Testing

• Was not yet able to run tests yet (Happy for any help)
• image-ssr-build.test.js does include a test with query string the other tests dont. Should we maybe unify all the tests that we always test the same images in all image-ssr-build/dev/ssg and also picture?

Docs

As it is a bugfix, there is no documentation added.

Fixes #4996

[changeset-bot]

🦋 Changeset detected

Latest commit: 859ddf4

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[tony-sull]

Thanks for opening this PR, always great to see a new issue and a bug fix PR opened at the same time!

I'm really curious why this is passing in the <Image /> test but doesn't work for <Picture />, let me dig in a little more and see exactly what's going on.

💯 agree it would be nice to have the tests refactored a little more to align what images are used. A few cases only make sense for <Image /> like the "no transforms" test case, but that shouldn't block a good refactor here

[tony-sull]

Ah ha, getPicture() has to do an extname check that isn't needed for getImage() and it wasn't account for query params

@panwauu You were spot on with the removeQueryParams() check, I just moved it down a level into basename in case another code path ever hits it directly with query params. I didn't refactor the test suite but that's a great idea, in the meantime I added a couple missing test cases to the SSG picture suite

Feel free to reach out if you're interested in working on a test refactor here! Happy to help get you setup to run the tests locally and walk through how they're working today 🙌

[tony-sull]

This is the bug fix, basename should be stripping off query params