Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astro image cache dependency fix scottaw66 #4944

Merged
merged 2 commits into from
Oct 1, 2022
Merged

Astro image cache dependency fix scottaw66 #4944

merged 2 commits into from
Oct 1, 2022

Conversation

scottaw66
Copy link
Contributor

Changes

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can help as well.
  • Don't forget a changeset! pnpm exec changeset

Change in astro image (/packages/integrations/image). Moved 'http-cache-semantics' package from dev-dependency to dependency to resolve error "Cannot find package 'http-cache-semantics' imported from /Volumes/BFD/Sites/scottwillsey2.0/node_modules/@astrojs/image/dist/build/ssg.js"

Testing

ran "pnpm run test:match "image"

Docs

No doc changes needed

No change in component functionality or use method. Fixing runtime error for component dependency.

@changeset-bot
Copy link

changeset-bot bot commented Oct 1, 2022

🦋 Changeset detected

Latest commit: 86172a9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Oct 1, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@natemoo-re natemoo-re merged commit a8f1a91 into withastro:main Oct 1, 2022
@astrobot-houston astrobot-houston mentioned this pull request Oct 1, 2022
@scottaw66 scottaw66 deleted the astro-image-cache-dependency-fix-scottaw66 branch October 1, 2022 04:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants